These docs are definitely in need of improving. Anything you haven't understood/needs clarifying/etc, anywhere you had to read the source code, try to write it down!
If you can, edit the docs that are there already & send a PR or add a new docs page with your info in it, but if you're not sure where to put it or even if it's relevant to anyone else, simply jot some thoughts/bullet points down in the
docs/wip directory and send a PR. I'll find a place for it!
# in the FAB project root cd docs yarn yarn docz:dev
If you're looking to add any code/fix bugs in the core plugins, the most important thing is to extend the E2E tests to cover them. There's quite a few unit tests there, and they have definitely helped, but given the nature of the FAB project, it makes more sense to do exactly what a user would do:
- Take a project
- Configure it for FABs
- Serve the FAB and expect some result
In one terminal:
# in the FAB project root yarn yarn build yarn link-all yarn build:watch
In a second terminal:
# from the FAB project root cd tests yarn yarn test
This will run a
create-react-app and a
nextjs test suite, where it creates a new project (using CRA or
create-next-app), then runs
fab init, then runs
fab build, then runs
fab serve fab.zip. It should pass on your machine, if doesn't raise an issue!
This test takes a long time, so to rerun the tests use the following command:
# in the fab/tests dir FAB_E2E_SKIP_CREATE=true yarn test create-react-app
# in the fab/tests dir FAB_E2E_SKIP_CREATE=true yarn test nextjs
Personally, I like to spin up a third console window and
cd into the
[cra|nextjs]-test dir and run
fab build &
fab serve fab.zip manually, then tweak the source code or config and rerun.
Because you ran
yarn link-all back in the first terminal window, and because
yarn build:watch is running in the background, changes you make to any of the FAB plugins should be instantly available. If they're not, check the output of
yarn build:watch, there's probably typescript errors.
Once you have recreated the bug/situation you're interested in, update the tests to automatically change the blank project to your desired state as a separate step after all the others (see the existing tests there, that's how things work already). Then rerun your
FAB_E2E_... yarn test ... and it should reset your test project and then configure it back to the state you're interested in.
Now you've got your setup, you can add expectations of what should happen to the tests, plus any FAB core code to fix them! Once it passes, fire up a PR and make sure it passes on Github CI as well, then you're done!